-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testdata): enable seeding via configMap, remove consortia files #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to the comment in the portal-backend eclipse-tractusx/portal-backend#957 (review)
I'd find it more sustainable to remove the files or better even enable a configmap for them: #207
@evegufy adjusted to configmaps and added those for the test data |
dead95f
to
09d3e27
Compare
09d3e27
to
ba6db7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the configmap needs to be enabled in the migrations job, for reference: https://github.com/eclipse-tractusx/portal/pull/356/files#diff-f8a9bb329bf6c13a5c05c4e939605e5700986b80c8aaaa0a9e51624d1002a8eaR89
2e46817
to
775542e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please update the pr title and description and also mention #207
charts/ssi-credential-issuer/templates/configmap-seeding-testdata.yaml
Outdated
Show resolved
Hide resolved
charts/ssi-credential-issuer/templates/job-issuer-migrations.yaml
Outdated
Show resolved
Hide resolved
charts/ssi-credential-issuer/templates/job-issuer-migrations.yaml
Outdated
Show resolved
Hide resolved
charts/ssi-credential-issuer/templates/job-issuer-migrations.yaml
Outdated
Show resolved
Hide resolved
charts/ssi-credential-issuer/templates/job-issuer-migrations.yaml
Outdated
Show resolved
Hide resolved
charts/ssi-credential-issuer/templates/job-issuer-migrations.yaml
Outdated
Show resolved
Hide resolved
charts/ssi-credential-issuer/templates/job-issuer-migrations.yaml
Outdated
Show resolved
Hide resolved
b6547a7
to
4a77680
Compare
4a77680
to
50feaef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
charts/ssi-credential-issuer/templates/job-issuer-migrations.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needed to do some changes, it's tested successfully now
Quality Gate passedIssues Measures |
Description
remove seeding files from consortia and enable the option to seed testdata via configMaps instead
Why
the ending consortia isn't really matching anymore, since the provided data are just test data
and to keep test data separated from other seeding data
Issue
Refs: #205, #207
Checklist