Skip to content

Commit

Permalink
Replace "1.8" with "8" for maven compiler
Browse files Browse the repository at this point in the history
Unfortunately those values are not interchangeable anymore, when using
the release attribute.
  • Loading branch information
Bananeweizen authored and github-actions[bot] committed Dec 6, 2024
1 parent 6fce47c commit 3de75f3
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions demo/osgi-repository/my-bundle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
</parent>
<artifactId>my-bundle</artifactId>
<properties>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
</properties>
<dependencies>
<dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,22 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.eclipse.tycho.tychoits.TYCHO590</groupId>
<artifactId>annotated-project</artifactId>

<parent>
<groupId>org.eclipse.tycho.tychoits.TYCHO590</groupId>
<artifactId>parent</artifactId>
<version>1.0.0-SNAPSHOT</version>
</parent>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.10.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
<source>8</source>
<target>8</target>
<fork>false</fork>
<compilerId>jdt</compilerId>
<annotationProcessors>
Expand Down
6 changes: 3 additions & 3 deletions tycho-its/projects/TYCHO590annotationProcessing/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<artifactId>parent</artifactId>
<version>1.0.0-SNAPSHOT</version>
<packaging>pom</packaging>

<modules>
<module>annotation-processor</module>
<module>annotated-project</module>
Expand All @@ -18,8 +18,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.10.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
<source>8</source>
<target>8</target>
<fork>false</fork>
<compilerId>jdt</compilerId>
</configuration>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
<properties>
<maven.compiler.release>17</maven.compiler.release>
</properties>

<dependencies>
<!-- Adding another dependency just to verify that also transitive dependencies
<!-- Adding another dependency just to verify that also transitive dependencies
get resolved and added to the javadoc execution class path -->
<dependency>
<groupId>org.eclipse.tycho</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</parent>
<artifactId>org.eclipse.tycho.bnd.executionlistener</artifactId>
<properties>
<min.jdk.version>1.8</min.jdk.version>
<min.jdk.version>8</min.jdk.version>
</properties>
<dependencies>
<dependency>
Expand Down

0 comments on commit 3de75f3

Please sign in to comment.