Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use helper for create memory composite #3413

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 26, 2024

Instead of going through the managers to create a composite repos, just do it directly and get better error reporting and less disturbing.

As seen in this run where it fails to choose a random URI:

So lets see if this makes anything worse...

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Jan 26, 2024
Copy link

github-actions bot commented Jan 26, 2024

Test Results

  585 files  ±0    585 suites  ±0   3h 30m 37s ⏱️ - 25m 19s
  394 tests ±0    386 ✅ +1   7 💤 ±0  1 ❌ ±0 
1 182 runs  ±0  1 159 ✅ +1  22 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 6c81942. ± Comparison against base commit 803f7eb.

♻️ This comment has been updated with latest results.

Instead of going through the managers to create a composite repos, just
do it directly and get better error reporting and less disturbing.
@laeubi laeubi force-pushed the dont_use_helper_for_composite branch from c87e127 to 6c81942 Compare February 10, 2024 19:17
@laeubi laeubi merged commit c9e3fe9 into eclipse-tycho:main Feb 12, 2024
9 of 11 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant