Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TargetDefinition#implicitDependencies #4528

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 14, 2024

PDE has support for implicitDependencies defined in the target that Tycho currently ignores.

This adds the required support to Tycho to understand dependencies defined in this way.

Copy link

github-actions bot commented Dec 14, 2024

Test Results

  603 files    603 suites   4h 12m 35s ⏱️
  432 tests   425 ✅  7 💤 0 ❌
1 296 runs  1 274 ✅ 22 💤 0 ❌

Results for commit 2fb7091.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the support_implicit_dependencies branch 2 times, most recently from fe73236 to 485b58c Compare December 15, 2024 12:03
@laeubi laeubi marked this pull request as ready for review December 15, 2024 12:03
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Dec 15, 2024
@laeubi laeubi enabled auto-merge (rebase) December 15, 2024 12:03
@laeubi laeubi force-pushed the support_implicit_dependencies branch 2 times, most recently from 5ee0229 to 25b32ff Compare December 15, 2024 12:36
PDE has support for implicitDependencies defined in the target that
Tycho currently ignores.

This adds the required support to Tycho to understand dependencies
defined in this way.
@laeubi laeubi force-pushed the support_implicit_dependencies branch from 25b32ff to 2fb7091 Compare December 16, 2024 08:43
@laeubi laeubi merged commit dd0c8df into eclipse-tycho:main Dec 16, 2024
15 checks passed
@eclipse-tycho-bot
Copy link

💔 All backports failed

Status Branch Result
tycho-4.0.x Backport failed because of merge conflicts

You might need to backport the following PRs to tycho-4.0.x:
- Add support for bumping maven-target locations
- Add p2-aware model converter for CycloneDX SBOM generation
- Skip CHECK_TRUST phase and allow parallel execution of product assembly
- Add support to specify target locations in the pom configuration
- Support javac as a compiler for Tycho
- Add support for API Tools Annotations to Tycho
- Support repository references

Manual backport

To create the backport manually run:

backport --pr 4528

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants