Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slim project config #246

Merged
merged 16 commits into from
May 3, 2024
Merged

Conversation

dennismeister93
Copy link
Contributor

This PR will slim our .velocitas.json to something like:

{
    "packages": {
        "https://github.com/eclipse-velocitas/pkg-velocitas-main.git": "v0.0.x",
        "https://github.com/eclipse-velocitas/devenv-devcontainer-setup.git": "v2.0.0",
        "devenv-runtimes": "^v2.0.0",
        "https://github.com/eclipse-velocitas/devenv-github-templates.git": "v1.0.*",
        "https://github.com/eclipse-velocitas/devenv-github-workflows.git": "v5.0.0"
    },
    "components": [
        "vapp-core-python",
        "devcontainer-setup",
        "sdk-installer",
        "runtime-local",
        "runtime-kanto",
        "deployment-kanto",
        "github-templates",
        "github-workflows"
    ],
    "variables": {
        "appManifestPath": "./app/AppManifest.json",
        "test@devenv-runtimes": 123,
        "blabla@runtime-local": "huhu",
        "githubRepoId": "<myrepo>"
    },
    "cliVersion": "v0.0.0"
}

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93 dennismeister93 marked this pull request as draft April 11, 2024 13:33
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93 dennismeister93 marked this pull request as ready for review April 13, 2024 18:52
@dennismeister93 dennismeister93 changed the title WIP: slim project config feat: slim project config Apr 13, 2024
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
README.md Outdated Show resolved Hide resolved
src/modules/project-config.ts Outdated Show resolved Hide resolved
src/modules/project-config.ts Outdated Show resolved Hide resolved
src/utils/configFileParser.ts Outdated Show resolved Hide resolved
src/utils/configFileParser.ts Outdated Show resolved Hide resolved
src/utils/configFileParser.ts Outdated Show resolved Hide resolved
src/utils/configFileParser.ts Outdated Show resolved Hide resolved
src/modules/project-config.ts Outdated Show resolved Hide resolved
src/utils/configFileParser.ts Outdated Show resolved Hide resolved
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
…andling

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
src/modules/package-downloader.ts Outdated Show resolved Hide resolved
src/modules/projectConfig/projectConfig.ts Outdated Show resolved Hide resolved
src/modules/projectConfig/projectConfigFileReader.ts Outdated Show resolved Hide resolved
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dennismeister93 dennismeister93 merged commit 1383f3d into main May 3, 2024
7 checks passed
@dennismeister93 dennismeister93 deleted the feature/slim-project-config branch May 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants