Add Package Parameter to Init #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested Scenarios: velocitas init -p devenv-github-workflows@v5.0.0 velocitas init -p https://github.com/eclipse-velocitas/devenv-github-workflows.git@v5.0.0 Use Cases: 'velocitas init -p devenv-runtimes@v3.0.0'
'velocitas init -p devenv-runtimes'
'velocitas init'
Edge Cases:
e.g.: init -p packageB Did not test:
|
|
🤷 |
wba2hi
commented
Apr 25, 2024
wba2hi
commented
Apr 25, 2024
wba2hi
commented
Apr 25, 2024
wba2hi
commented
Apr 25, 2024
dennismeister93
requested changes
Apr 25, 2024
It is now possible to initialize a standard package using `velocitas init -p devenv-runtimes`. This command will depending on if the devenv-runtimes package is defined in .velocitas.json use the version specified in .velocitas.json or use the latest version if not specified in .velocitas.json. Using a custom version: `velocitas init -p devenv-runtimes@v3.0.0`. Using a custom package: `velocitas init -p https://github.com/SoftwareDefinedVehicle/devenv-runtimes.git@v3.0.0` If initializing a package which is not part of .velocitas.json it will automatically be added to it. If a package specifies components but no component is referenced in .velocitas.json, all components will be added automatically during initialization.
Changed the @ version annotation of repos to a separate parameter.
This is necessary due to some clashes which we have when providing
a repo using ssh git urls. ssh git repo urls may contain look like
the folllwing: {user}:{password}@github.com/eclipse-velocitas/repo.git
However this paired with the previous version annotation
{repo_url}@v1.2.3 and the fact that both credentials and version
can optionally be provided makes reliably parsing the version out
of the url pretty hard.
If no specifier parameter is used, it will always retrieve the
latest version.
wba2hi
force-pushed
the
feature/init-with-package
branch
from
d07bb6d
to
59665b8
Compare
wba2hi
force-pushed
the
feature/init-with-package
branch
from
02fef36
to
24b0b0a
Compare
dennismeister93
requested changes
Apr 29, 2024
dennismeister93
requested changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to initialize a standard package using
velocitas init -p devenv-runtimes. This command will depending on if the devenv-runtimes package is defined in .velocitas.json use the version specified in .velocitas.json or use the latest version if not specified in .velocitas.json.Using a custom version:
velocitas init -p devenv-runtimes@v3.0.0.Using a custom package:
velocitas init -p https://github.com/SoftwareDefinedVehicle/devenv-runtimes.git@v3.0.0If initializing a package which is not part of .velocitas.json it will automatically be added to it. If a package specifies components but no component is referenced in .velocitas.json, all components will be added automatically during initialization.