5049 fix pipe race condition #5050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue: eclipse-vertx#5049 Signed-off-by: Nils Renaud <renaud.nils@gmail.com>
PipeTest#testFailStreamPrematurely was failing because the error handler is now activated before receiving the first element of the read stream. But, I think that's an error in the FakeStream implementation which calls the failure handler immediately, bypassing the content delivery. This means that the previous FakeThread implementation permitted: - multiple failure handler calls on the same Stream - A failure event THEN a new element read This, IMO does not respect the ReadStream behaviour. This test was only OK because the failure handler was set after the call to resume in the Pipe implementation. But it looks like a tweak to accommodate with the buggy FakeStream behavior. Signed-off-by: Nils Renaud <renaud.nils@gmail.com>
|
There is still a broken test |
|
@vietj what do you think of my previous comment, is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #5049