add submodules as dirs when build in vscode #202
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'dependencies', 'internal', 'breaking-change', 'enhancement', 'bug', 'new feature', 'documentation'} |
| @@ -39,7 +39,9 @@ endfunction() | |||
| # loaded as root project into vscode | |||
| # | |||
| function(declare_cache_var_true_if_vscode var docstring) | |||
| if(CMAKE_CURRENT_BINARY_DIR STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}/build") | |||
| if((CMAKE_CURRENT_BINARY_DIR STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}/build") AND | |||
There was a problem hiding this comment.
It is unclear why we should favor vscode over anything else.
|
Trying to install zenoh-cpp using this approch would lead to a lot of non-evident effects: i.e depending on zenoh-c/pico implementation the user-installed zenoh-c/pico libraries might be overwritten or otherwise nor zenoh-c nor zenoh-pico would be installed and thus the user will end up with a broken zenoh-cpp installation (i.e none of the zenoh-cpp dependent packages will work including zenoh-cpp standalone examples) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #201