Add Bytes serialization support for std::span #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'bug', 'dependencies', 'new feature', 'internal', 'breaking-change', 'enhancement', 'documentation'} |
examples/universal/z_bytes.cxx
Outdated
| @@ -17,6 +17,10 @@ | |||
| #include "entity.pb.h" | |||
| #endif | |||
|
|
|||
| #if __cplusplus >= 202002L | |||
There was a problem hiding this comment.
I think this is not necessary (especially given that we do not include other related stl headers) , since the corresponding header is already included by serialization.hxx.
There was a problem hiding this comment.
Thanks for the review! I removed it from the include directives
JafarAbdi
force-pushed
the
feature/span_bytes
branch
from
23c31b4
to
b8935a9
Compare
milyin
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easy to use old style arrays + pointers with size without allocating memory.