CI improvements (#273)

.clang-format

@@ -1,3 +1,5 @@
+---
+Language: Cpp
 BasedOnStyle: Google
 IndentWidth: 4
 ColumnLimit: 120

.github/workflows/arduino_esp32.yaml

@@ -29,7 +29,7 @@ jobs:
         os: [ubuntu-latest]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install requirements
         run: |

.github/workflows/build-check.yaml

@@ -20,6 +20,28 @@ on:
     branches: [ '**' ]
 
 jobs:
+  run_tests: 
+    name: Run unit tests on ubuntu-latest
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Build & run tests
+        run: |
+          sudo apt install -y ninja-build
+          CMAKE_GENERATOR=Ninja make test
+  
+  check_format:
+    name: Check codebase format with clang-format
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Run clang-format dry-run
+        run: find include/ src/ tests/ examples/ -iname "*.ino" -o -iname "*.h" -o -iname "*.c" | xargs clang-format -n -Werror
+
   modular_build:
     name: Modular build on ubuntu-latest
     runs-on: ubuntu-latest
@@ -38,7 +60,8 @@ jobs:
 
     - name: Build project
       run: |
-        make all
+        sudo apt install -y ninja-build
+        CMAKE_GENERATOR=Ninja make
         python3 ./build/tests/modularity.py --pub $Z_FEATURE_PUBLICATION --sub $Z_FEATURE_SUBSCRIPTION --queryable $Z_FEATURE_QUERYABLE --query $Z_FEATURE_QUERY
       timeout-minutes: 5
       env:
@@ -51,4 +74,4 @@ jobs:
       if: always()
       run: |
         docker stop zenoh_router
-        docker rm zenoh_router
+        docker rm zenoh_router

.github/workflows/build-shared.yaml

@@ -28,7 +28,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Compile debug
       run: make all
       env:
@@ -44,10 +44,10 @@ jobs:
     name: Build on ubuntu-latest
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Crosscompile debug
       run: make crossbuilds
       env:
         BUILD_TYPE: Debug
         BUILD_SHARED_LIBS: ON
-        ZENOH_DEBUG: 3
+        ZENOH_DEBUG: 3

.github/workflows/build-static.yaml

@@ -28,7 +28,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Compile debug
       run: make all
       env:
@@ -44,7 +44,7 @@ jobs:
     name: Build on ubuntu-latest
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Crosscompile debug
       run: make crossbuilds
       env:

.github/workflows/codacy-analysis.yml

@@ -21,7 +21,7 @@ jobs:
     steps:
       # Checkout the repository to the GitHub Actions runner
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       # Execute Codacy Analysis CLI and generate a SARIF output with the security issues identified during the analysis
       - name: Run Codacy Analysis CLI

.github/workflows/emscripten.yaml

@@ -28,13 +28,11 @@ jobs:
       matrix:
         os: [ubuntu-latest]
     steps:
-    - uses: actions/checkout@v2
-    - uses: jwlawson/actions-setup-cmake@v1.13
-    - uses: mymindstorm/setup-emsdk@v11
+    - uses: actions/checkout@v4
+    - uses: jwlawson/actions-setup-cmake@v1.14
+    - uses: mymindstorm/setup-emsdk@v12
     - name: Compile debug
       run: |
        mkdir build
        emcmake cmake -E env CFLAGS="-DZ_FEATURE_LINK_WS=1 -DZ_FEATURE_LINK_TCP=0 -DZ_FEATURE_LINK_UDP_MULTICAST=0 -DZ_FEATURE_LINK_UDP_UNICAST=0 -DZ_FEATURE_SCOUTING_UDP=0" cmake -DBUILD_SHARED_LIBS=OFF -DCMAKE_C_STANDARD=11 -DBUILD_EXAMPLES=OFF -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=OFF -DBUILD_MULTICAST=OFF -DBUILD_INTEGRATION=OFF -DBUILD_TOOLS=OFF -DZENOH_DEBUG=3 -H. -Bbuild
        make -C build
-
-

.github/workflows/espidf.yaml

@@ -29,7 +29,7 @@ jobs:
         os: [ubuntu-latest]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install requirements
         run: |

.github/workflows/freertos_plus_tcp.yaml

@@ -28,7 +28,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - uses: jwlawson/actions-setup-cmake@v1.13
     - name: Install requirements
       run: |

.github/workflows/integration.yaml

@@ -32,10 +32,10 @@ jobs:
         os: [ ubuntu-latest, macOS-latest ]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install latest stable
-        uses: actions-rs/toolchain@v1
+        uses: actions-rs/toolchain@v1.0.7
         with:
           toolchain: stable
           override: true

.github/workflows/mbed.yaml

@@ -29,7 +29,7 @@ jobs:
         os: [ubuntu-latest]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install requirements
         run: |

.github/workflows/multicast.yaml

@@ -31,7 +31,7 @@ jobs:
         os: [macOS-latest]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Compile debug
         run: make all

.github/workflows/release.yml

@@ -25,7 +25,7 @@ jobs:
     name: Preparation
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Environment setup
         id: env
         shell: bash
@@ -73,7 +73,7 @@ jobs:
     needs: preps
     runs-on: macos-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: MacOS build
         run: make
         env:
@@ -108,7 +108,7 @@ jobs:
       fail-fast: false
       matrix: ${{fromJson(needs.preps.outputs.TARGET_MATRIX)}}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: make for ${{ matrix.target }}
         env:
           BUILD_TYPE: RELEASE

.github/workflows/zephyr.yaml

@@ -29,7 +29,7 @@ jobs:
         os: [ubuntu-latest]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install requirements
         run: |

CMakeLists.txt

@@ -138,7 +138,7 @@ endif()
 
 if(CMAKE_BUILD_TYPE MATCHES "DEBUG")
   if(UNIX)
-    add_compile_options(-c -Wall -Wextra -Werror -Wunused -Wstrict-prototypes -pipe -g -O0)
+    add_compile_options(-c -Wall -Wextra -Werror -Wshadow -Wpedantic -Wunused -Wstrict-prototypes -pipe -g -O0)
   elseif(MSVC)
     add_compile_options(/W4 /WX /Od)
   elseif(CMAKE_SYSTEM_NAME MATCHES "Generic")

examples/arduino/z_get.ino

@@ -122,6 +122,7 @@ void loop() {
 #else
 void setup() {
     Serial.println("ERROR: Zenoh pico was compiled without Z_FEATURE_QUERY but this example requires it.");
+    return;
 }
 void loop() {}
 #endif

examples/arduino/z_pub.ino

@@ -111,6 +111,7 @@ void loop() {
 #else
 void setup() {
     Serial.println("ERROR: Zenoh pico was compiled without Z_FEATURE_PUBLICATION but this example requires it.");
+    return;
 }
 void loop() {}
 #endif

examples/arduino/z_pull.ino

@@ -112,6 +112,7 @@ void loop() {
 #else
 void setup() {
     Serial.println("ERROR: Zenoh pico was compiled without Z_FEATURE_SUBSCRIPTION but this example requires it.");
+    return;
 }
 void loop() {}
 #endif

examples/arduino/z_queryable.ino

@@ -111,6 +111,7 @@ void loop() { delay(5000); }
 #else
 void setup() {
     Serial.println("ERROR: Zenoh pico was compiled without Z_FEATURE_QUERYABLE but this example requires it.");
+    return;
 }
 void loop() {}
 #endif

examples/arduino/z_sub.ino

@@ -109,6 +109,7 @@ void loop() { delay(5000); }
 #else
 void setup() {
     Serial.println("ERROR: Zenoh pico was compiled without Z_FEATURE_SUBSCRIPTION but this example requires it.");
+    return;
 }
 void loop() {}
-#endif
+#endif

examples/espidf/z_get.c

@@ -175,4 +175,4 @@ void app_main() {
 }
 #else
 void app_main() { printf("ERROR: Zenoh pico was compiled without Z_FEATURE_QUERY but this example requires it.\n"); }
-#endif
+#endif

examples/espidf/z_pull.c

@@ -173,4 +173,4 @@ void app_main() {
 void app_main() {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_SUBSCRIPTION but this example requires it.\n");
 }
-#endif
+#endif

examples/espidf/z_sub.c

@@ -171,4 +171,4 @@ void app_main() {
 void app_main() {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_SUBSCRIPTION but this example requires it.\n");
 }
-#endif
+#endif

examples/freertos_plus_tcp/include/FreeRTOSIPConfig.h

@@ -51,4 +51,4 @@
 #define ipconfigBUFFER_PADDING 14U
 #endif
 
-#endif /* FREERTOS_IP_CONFIG_H */
+#endif /* FREERTOS_IP_CONFIG_H */

examples/freertos_plus_tcp/z_get.c

@@ -98,4 +98,4 @@ void app_main(void) {
 void app_main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_QUERY but this example requires it.\n");
 }
-#endif
+#endif

examples/freertos_plus_tcp/z_queryable.c

@@ -94,4 +94,4 @@ void app_main(void) {
 void app_main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_QUERYABLE but this example requires it.\n");
 }
-#endif
+#endif

examples/mbed/z_get.cpp

@@ -100,4 +100,4 @@ int main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_QUERY but this example requires it\n");
     return -2;
 }
-#endif
+#endif

examples/mbed/z_pub.cpp

@@ -91,4 +91,4 @@ int main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_PUBLICATION but this example requires it.\n");
     return -2;
 }
-#endif
+#endif

examples/mbed/z_pull.cpp

@@ -97,4 +97,4 @@ int main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_SUBSCRIPTION but this example requires it.\n");
     return -2;
 }
-#endif
+#endif

examples/mbed/z_queryable.cpp

@@ -100,4 +100,4 @@ int main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_QUERYABLE but this example requires it.\n");
     return -2;
 }
-#endif
+#endif

examples/mbed/z_sub.cpp

@@ -95,4 +95,4 @@ int main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_SUBSCRIPTION but this example requires it.\n");
     return -2;
 }
-#endif
+#endif

examples/unix/c11/z_get.c

@@ -105,7 +105,8 @@ int main(int argc, char **argv) {
     char c = '\0';
     while (1) {
         fflush(stdin);
-        scanf("%c", &c);
+        int ret = scanf("%c", &c);
+        (void)ret;  // Remove unused result warning
         if (c == 'q') {
             break;
         }
@@ -135,4 +136,4 @@ int main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_QUERY but this example requires it.\n");
     return -2;
 }
-#endif
+#endif

examples/unix/c11/z_ping.c

@@ -179,4 +179,4 @@ int main(void) {
         "requires them.\n");
     return -2;
 }
-#endif
+#endif

examples/unix/c11/z_pong.c

@@ -76,4 +76,4 @@ int main(void) {
         "requires them.\n");
     return -2;
 }
-#endif
+#endif

examples/unix/c11/z_pub_st.c

@@ -109,4 +109,4 @@ int main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_PUBLICATION but this example requires it.\n");
     return -2;
 }
-#endif
+#endif

examples/unix/c11/z_pull.c

@@ -82,7 +82,8 @@ int main(int argc, char **argv) {
     char c = '\0';
     while (1) {
         fflush(stdin);
-        scanf("%c", &c);
+        int ret = scanf("%c", &c);
+        (void)ret;  // Remove unused result warning
         if (c == 'q') {
             break;
         }
@@ -104,4 +105,4 @@ int main(void) {
     printf("ERROR: Zenoh pico was compiled without Z_FEATURE_SUBSCRIPTION but this example requires it.\n");
     return -2;
 }
-#endif
+#endif