-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor transport layer #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cguimaraes
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible avoid the early returns, unless they are really needed.
If you still keep them, document them (including the reason).
Mallets
reviewed
Nov 13, 2023
Mallets
reviewed
Nov 13, 2023
cguimaraes
reviewed
Nov 14, 2023
jean-roland
force-pushed
the
rfct_transport
branch
from
November 14, 2023 08:52
c79d74d
to
20640af
Compare
jean-roland
commented
Nov 14, 2023
Mallets
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport layer refactor to improve maintainability and modularity in prevision of adding a new transport.
Instead of compile-time specific code removal spread everywhere, files call functions that are swapped to dummy versions when the feature is removed.
This may increase slightly code size when removing the feature but makes it much easier to expand the number of transports.