Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy z_config_peer/z_config_client methods #641

Merged

Conversation

sashacmc
Copy link
Member

Closes: #640

Copy link

PR missing one of the required labels: {'dependencies', 'enhancement', 'internal', 'breaking-change', 'new feature', 'documentation', 'bug'}

@sashacmc sashacmc added the enhancement Things could work better label Sep 10, 2024
@sashacmc sashacmc marked this pull request as ready for review September 10, 2024 15:52
@@ -1,49 +0,0 @@
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we still have a test verifying that get/set operations work for the config ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have it in z_api_alignment_test.c

@milyin milyin merged commit 4b9e89c into eclipse-zenoh:main Sep 10, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy z_config_peer/z_config_client methods
3 participants