Add manual batching mechanism #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'new feature', 'enhancement', 'dependencies', 'internal', 'breaking-change', 'documentation', 'bug'} |
sashacmc
reviewed
Oct 23, 2024
sashacmc
approved these changes
Oct 24, 2024
jean-roland
added a commit
to jean-roland/zenoh-pico
that referenced
this pull request
Nov 13, 2024
* feat: add _vec_steal and _vec_null * chore: remove stray ; * feat: add network message copy function * fix: memory leak * feat: abstract transport mutex * build: add batching config token * feat: add transport batching state functions * feat: add multicast batching * refactor: unicast tx function * feat: add unicast tx batching * feat: add batching api * fix: multicast peer mutex * fix: single thread compilation * feat: restore wbuf if batch if too full * fix: redundant buf reset * feat: pass sn by value * feat: send fragment with batching if needed * feat: rename batch api functions * feat: switch transport mutex functions to static inline * doc: add batching api doc * fix: boolean condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #298. This adds an API to do manual batching which yields improved throughput performance for smaller packets.
User can start batching with
zp_start_batching, any subsequent api call that would have put a network message (z_put,z_get,z_declare...) is bufferized to be later sent as a batch (or multiple batches) when user callszp_stop_batching.While I was modifying the transports I decided to refactor a little because the functions were too complicated to parse.