Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform_common.c to zephyr CMakeLists.txt file #778

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Add platform_common.c to zephyr CMakeLists.txt file #778

merged 1 commit into from
Nov 7, 2024

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Nov 6, 2024 •
edited
Loading

Closes: #775

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

PR missing one of the required labels: {'enhancement', 'internal', 'new feature', 'breaking-change', 'documentation', 'dependencies', 'bug'}

@sashacmc sashacmc added the bug Something isn't working label Nov 6, 2024
@sashacmc sashacmc mentioned this pull request Nov 6, 2024
Closed
@sashacmc sashacmc marked this pull request as ready for review November 6, 2024 13:17
WilliamGFish
WilliamGFish suggested changes Nov 6, 2024
View reviewed changes
Copy link

@WilliamGFish WilliamGFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLOB_RECURSE includes the subdirectories, hence pulls in all other platform files.

external/zenoh-pico/src/system/arduino/esp32/system.c:15:10: fatal error: Arduino.h: No such file or directory
15 | #include <Arduino.h>

zephyr/CMakeLists.txt Outdated Show resolved Hide resolved
@Mallets Mallets merged commit 7cffd69 into eclipse-zenoh:main Nov 7, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamGFish WilliamGFish WilliamGFish approved these changes

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] zenoh-pico: zephyr: Compilation Errors
3 participants
@sashacmc @Mallets @WilliamGFish