Ensure getCodeActions() always returns a list and not null. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #449
Fixes the exception
Cannot invoke "java.util.Collection.toArray()" because "<parameter1>" is nullIn each case we run code like:
codeActions.addAll(AddPathParamQuickFix.getCodeActions(context, diagnostic, monitor));and null is not a valid arg to
addAll(). This usually does not happen because usually the program is well formed and if the diagnostic can be detected then a quick fix can be created. However in some cases syntax errors are too severe and the quick fix creation fails and a null may be returned.