Export all commons.* packages from jakarta.jdt bundle #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this I hit a ClassCastException when trying to resolve a code action from the LSP4MP.
I was running into a scenario where one path resolved the code action data directly from the lsp4e bundle and the other path accessed it via my "client" bundle. The client also packages the "commons*" classes, but if we export them from jakarta.jdt we will consistently load them from this bundle rather than using our local client-packaged classes.
Leaving aside the other difficulties with the LSP4MP code action above, it seemed like this could be fixed independently.