add quickfix fn to handle composite annotations #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mezarin
reviewed
Feb 9, 2024
| } | ||
| } | ||
| if (a instanceof SingleMemberAnnotation) { | ||
| // this type of annotation contains a single valuie which may be a list of other annotations, |
| @@ -19,19 +19,27 @@ | |||
| import java.util.List; | |||
|
|
|||
| import org.eclipse.core.runtime.CoreException; | |||
| import org.eclipse.jdt.core.IAnnotation; | |||
There was a problem hiding this comment.
Update copyright year to 2024 in this file and others.
|
|
||
| newSingleMemberAnnotation.setTypeName( | ||
| ast.newName(imports.addImport(annotationToProcess.getTypeName().toString(), importRWCtx))); | ||
| List<NormalAnnotation> newCompositeAnnotationContents = newAIInstance.expressions(); |
There was a problem hiding this comment.
It looks like you populate this: newCompositeAnnotationContents, but it is never used.
| } | ||
|
|
||
| // add new String attributes | ||
| //values = addNewAttributes(ast, values); |
There was a problem hiding this comment.
Remove this commented line.
| } | ||
|
|
||
| // process methods now? |
There was a problem hiding this comment.
Remove: // process methods now?
|
|
||
| @Resource(type = Object.class, name = "aa") | ||
| @Resources ({ @Resource(name = "aaa"), @Resource(type = Object.class) }) |
There was a problem hiding this comment.
A couple of things here:
- You may want to format this file.
- Why replace @resource for @Resources? That could be used for a positive test where we check that no diagnostics are generated because everything looks fine.
- I would suggest that you create a ResourcesAnnotation class and add a similar set of code for a similar set of diagnostics/code-action tests including a positive test.
ajm01
force-pushed
the
issue-190
branch
2 times, most recently
from
e2240f8
to
14793a0
Compare
mezarin
reviewed
Feb 23, 2024
| @@ -28,6 +28,7 @@ public enum JakartaCodeActionId implements ICodeActionId { | |||
| ChangeReturnTypeToVoid, | |||
| InsertResourceAnnotationTypeAttribute, | |||
| InsertResourceAnnotationNameAttribute, | |||
There was a problem hiding this comment.
Update Copyright year to 2024
| @@ -30,6 +30,10 @@ public class Constants { | |||
| public static final String RESOURCE = "Resource"; | |||
| public static final String RESOURCE_FQ_NAME = "jakarta.annotation.Resource"; | |||
|
|
|||
| /* @Resources */ | |||
There was a problem hiding this comment.
Update Copyright year to 2024
| @@ -18,6 +18,7 @@ MethodMustNotHaveParameters = A method with the {0} annotation must not have any | |||
| MethodMustBeVoid = A method with the {0} annotation must be void. | |||
| MethodMustNotBeStatic = A method with the {0} annotation must not be static. | |||
| MethodMustNotThrow = A method with the {0} annotation must not throw checked exceptions. | |||
| ResourcesAnnotationMustDefineResourceAnnotation = The {0} annotation must define at least one sub-annotation ''{1}''. | |||
There was a problem hiding this comment.
Update Copyright year to 2024
| @@ -0,0 +1,78 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
Since this is a new file the first like should be:
Copyright (c) 2024 IBM Corporation and others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #190