Fixes #416 - Quick-fix fails due to getData() is null #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkeylurkey
requested changes
Nov 13, 2024
| import java.util.stream.Collectors; | ||
|
|
||
| import org.eclipse.lsp4j.CodeActionContext; | ||
| import org.eclipse.lsp4j.Diagnostic; | ||
| import org.eclipse.lsp4j.Position; | ||
| import org.eclipse.lsp4j.Range; | ||
| import org.eclipse.lsp4j.TextDocumentIdentifier; | ||
| import org.eclipse.lsp4jakarta.jdt.internal.beanvalidation.RemoveDynamicConstraintAnnotationQuickFix; |
There was a problem hiding this comment.
Please remove this unused import.
| public static Object getValueFromDataParameter(Map<String, Object> data, String key) { | ||
|
|
||
| Object child = data.get(key); | ||
| if (child != null && child instanceof String) { |
There was a problem hiding this comment.
You do not need this null check because child will not be an instance of String if it is null. Please remove the null check.
|
|
||
| Object child = data.get(key); | ||
| if (child != null && child instanceof String) { | ||
| // if the value in the 'data' is a string, we string the object. |
There was a problem hiding this comment.
This code does not line up because there is a tab character on the line. Please remove the tab and replace with 4 spaces.
The same goes for the following line, the two comment lines in the next if block and one comment line in the subsequent else block.
| return jsonArray; | ||
| } else { | ||
| //Returns the object if it exists and is an object, and null otherwise | ||
| return getObject(data, key); |
There was a problem hiding this comment.
Could you clarify why we need this line? It checks if the data is a Map?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
Quick-fix fails due to getData() is null.
The root cause of the issue is lsp4Jakarta expects a Map object from VS Code, but we are sending a string or array of strings from VS code. Resolved the null pointer exception by adding code to handle both the 'data' format.
eg:
data = “AssertTrue”
data =[“ApplicationScoped", "RequestScoped”]