Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use java.nio.file instead of java.io #53

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Use java.nio.file instead of java.io #53

merged 2 commits into from
Apr 4, 2024

Conversation

dwalluck
Copy link
Contributor

No description provided.

@dwalluck dwalluck requested a review from ctron March 29, 2024 19:44
ctron
ctron requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I would either add some explanation of the deprecation, or drop those functions altogether.

@dwalluck
Copy link
Contributor Author

dwalluck commented Apr 2, 2024

Looks good. But I would either add some explanation of the deprecation, or drop those functions altogether.

If you're not concerned with maintaining backwards compatibility, then I would just drop them.

@ctron
Copy link
Contributor

ctron commented Apr 2, 2024

Looks good. But I would either add some explanation of the deprecation, or drop those functions altogether.

If you're not concerned with maintaining backwards compatibility, then I would just drop them.

I think we can push out another release, a breaking one.

@dwalluck
Copy link
Contributor Author

dwalluck commented Apr 3, 2024

I think we can push out another release, a breaking one.

I've removed the deprecated File-based methods.

@dwalluck dwalluck merged commit 919b021 into eclipse:master Apr 4, 2024
4 checks passed
@dwalluck dwalluck deleted the java-nio-file branch April 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctron ctron ctron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwalluck @ctron