Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move almost all remaining tests to internal org and reactivate tests #1218

Merged
merged 5 commits into from
May 17, 2021

Conversation

andre15silva
Copy link
Contributor

@andre15silva andre15silva commented May 14, 2021

Changelog

  • Move tests from external repos to internal repos
  • Move test builds from travis-ci.org to travis-ci.com
  • Fixed and reactivated test from TestMetrics4BearsJsonFile.java. The other one works locally but fails in CI (see Failing unit test due to leaks  #1219).

TODO

Signed-off-by: André Silva <andre15andre@hotmail.com>
Signed-off-by: André Silva <andre15andre@hotmail.com>
@andre15silva andre15silva changed the title Move almost all remaining tests to internal org and reactivate tests refactor: move almost all remaining tests to internal org and reactivate tests May 14, 2021
@andre15silva andre15silva force-pushed the move-tests-2 branch 5 times, most recently from 77912d2 to eb8c787 Compare May 15, 2021 11:51
Signed-off-by: André Silva <andre15andre@hotmail.com>
Signed-off-by: André Silva <andre15andre@hotmail.com>
Signed-off-by: André Silva <andre15andre@hotmail.com>
@monperrus
Copy link
Contributor

Excellent PR.

Move henry-lp/SonarQubeRepairTests to internal org and update

Do we do this here or in a subsequent PR?

@andre15silva
Copy link
Contributor Author

Do we do this here or in a subsequent PR?

Depends on how quick it gets moved. It's okay if we merge it as it is.

The only test depending on it is

and since it uses the GitHub launcher it should stay stable for quite some time (unlike the Travis ones), so it's really for consistency only.

@monperrus monperrus merged commit a7ba0ed into eclipse:master May 17, 2021
@monperrus
Copy link
Contributor

Very good, we proceed this way then. Thanks André!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants