Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure metadata serialization handles numpy.integer properly #140

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

japols
Copy link
Member

@japols japols commented Nov 20, 2024

This PR fixes a bug where int64 objects in the metadata raised TypeError: Object of type int64 is not JSON serializable by converting them to a python-native int.

@FussyDuck
Copy link

FussyDuck commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.96%. Comparing base (97c0a99) to head (0cb8f1c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #140   +/-   ##
========================================
  Coverage    72.96%   72.96%           
========================================
  Files           10       10           
  Lines          825      825           
========================================
  Hits           602      602           
  Misses         223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@japols japols merged commit b4626c2 into develop Nov 20, 2024
54 checks passed
@japols japols deleted the fix/metadata-np-int branch November 20, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants