Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of interpolation::method::SphericalVector and implementation of adjoint methods. #168

Merged
merged 57 commits into from
Feb 27, 2024
Merged

Refactoring of interpolation::method::SphericalVector and implementation of adjoint methods. #168

merged 57 commits into from
Feb 27, 2024

Commits on Jan 30, 2024

  1. Fixed test output file name.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d04b109 View commit details
    Browse the repository at this point in the history

  2. Added correct constness to geometry::UnitSphere::greatCircleCourse.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e3f38ec View commit details
    Browse the repository at this point in the history

  3. Removed unecessary RealMatrixMap definition.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    273e636 View commit details
    Browse the repository at this point in the history

  4. Added arrayForEachDim wrapper function.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    43ba1a0 View commit details
    Browse the repository at this point in the history

  5. Partially implemented Complex Matrix multiply class.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b796c1b View commit details
    Browse the repository at this point in the history

  6. Implimented ComplexMatrixMultiply class.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c6221e5 View commit details
    Browse the repository at this point in the history

  7. Further refactoring.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    275b8d5 View commit details
    Browse the repository at this point in the history

  8. Added adjoint tests.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7876f69 View commit details
    Browse the repository at this point in the history

  9. Adjusted test assert.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    96a7cad View commit details
    Browse the repository at this point in the history

  10. Attempting to solve MacOS nan issues.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a13b10b View commit details
    Browse the repository at this point in the history

  11. Added norm checks on fields.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    ca3295f View commit details
    Browse the repository at this point in the history

  12. Assigning targetField = 0. in test.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    82b3048 View commit details
    Browse the repository at this point in the history

  13. Static cast in dot product.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    718f1ae View commit details
    Browse the repository at this point in the history

  14. Added explicit NaN checking.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    be26276 View commit details
    Browse the repository at this point in the history

  15. Explicit types in NaN checking lambda parameters.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c4e85b7 View commit details
    Browse the repository at this point in the history

  16. Checking for IEEE 754 arithmetic support.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    db7df5b View commit details
    Browse the repository at this point in the history

  17. Added NaN checking to weight generation.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3610a46 View commit details
    Browse the repository at this point in the history

  18. Trying ArrayView assign instead of Array copy.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2bc48d0 View commit details
    Browse the repository at this point in the history

  19. Disabled halo-exchange.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    22b53e0 View commit details
    Browse the repository at this point in the history

  20. Addressed undefined behaviour with std::polar.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6838f5a View commit details
    Browse the repository at this point in the history

  21. Fixed StructuredColumns inaccuracies.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    207cc19 View commit details
    Browse the repository at this point in the history

  22. Update SphericalVector.h 

    Removed unnecessary headers.
    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7376c64 View commit details
    Browse the repository at this point in the history

  23. Update SphericalVector.cc 

    Removed unnecessary headers.
    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c69b9e6 View commit details
    Browse the repository at this point in the history

  24. Update test_interpolation_spherical_vector.cc 

    Removed initial error field assignment.
    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3f3ef60 View commit details
    Browse the repository at this point in the history

  25. Added missing header include.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8d57a4d View commit details
    Browse the repository at this point in the history

  26. Updated copyright.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3687035 View commit details
    Browse the repository at this point in the history

  27. Added low-to-high resolution structured interpolation test.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5f6fcbf View commit details
    Browse the repository at this point in the history

  28. Added high-to-low resolution structured interpolation test.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    01464c9 View commit details
    Browse the repository at this point in the history

  29. Restored test_array_foreach.cc.

    @odlomax
    odlomax committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c1abc2a View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Update ComplexMatrixMultiply.h 

    Fixed strange formatting.
    @odlomax
    odlomax authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    fb64d8f View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Addressed compilation failure when Eigen is disabled.

    @odlomax
    odlomax committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    0937745 View commit details
    Browse the repository at this point in the history

  2. Added eckit Eigen macros to SparseMatrix.h.

    @odlomax
    odlomax committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    be86d5e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/spherical_vector_adjoint' of https://github.com… 

    …/JCSDA-internal/atlas into feature/spherical_vector_adjoint
    @odlomax
    odlomax committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    eee0d6b View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Removed trial-and-error macros.

    @odlomax
    odlomax committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    3e2ab1f View commit details
    Browse the repository at this point in the history

  2. Implemented Eigen SparseMatrix iterators.

    @odlomax
    odlomax committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    45ad54e View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Separated out 2-vector and 3-vector MatMul methods. Replaced shared p… 

    …ointers with unique pointers.
    @odlomax
    odlomax committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    e13e6c3 View commit details
    Browse the repository at this point in the history

  2. Restored omp_parallel_for.

    @odlomax
    odlomax committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3bfc0c2 View commit details
    Browse the repository at this point in the history

  3. Updated self-destruct matrix class implemented when Eigen is disabled.

    @odlomax
    odlomax committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    231fc16 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Forced consistency between integral types.

    @odlomax
    odlomax committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    b376c96 View commit details
    Browse the repository at this point in the history

  2. Replaced adjoint move operation with copy.

    @odlomax
    odlomax committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4210cdb View commit details
    Browse the repository at this point in the history

  3. Added explicit on SparseMatrix private constructor.

    @odlomax
    odlomax committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c9902c3 View commit details
    Browse the repository at this point in the history

  4. Updated doxygen comment. SparseMatrix class no longe resembles eckit:… 

    …:SparseMatrix.
    @odlomax
    odlomax committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2736d08 View commit details
    Browse the repository at this point in the history

  5. Removed unecessary copy

    @odlomax
    odlomax committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    b292836 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Addressed partial override warning.

    @odlomax
    odlomax committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    7ef0859 View commit details
    Browse the repository at this point in the history

  2. Changed smart pointers to raw pointers.

    @odlomax
    odlomax committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    8e1484b View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Attempted to disable vectorisation if __NVCOMPILER is defined.

    @odlomax
    odlomax committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    fc64ae4 View commit details
    Browse the repository at this point in the history

  2. Fixed error on SparseMatrix dummy class.

    @odlomax
    odlomax committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    f9e1bec View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Turned off OpenMP when __NVCOMPILER is defined.

    @odlomax
    odlomax committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1996e27 View commit details
    Browse the repository at this point in the history

  2. Added stronger debug checks on weight matrices. Forced checks when __… 

    …NVCOMPILER is defined.
    @odlomax
    odlomax committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d13726b View commit details
    Browse the repository at this point in the history

  3. I forgot to actually disable OpenMP where it mattered. I've disabled … 

    …it properly now.
    @odlomax
    odlomax committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    c7c75bd View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Removed unnecessary macros.

    @odlomax
    odlomax committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1c58cb6 View commit details
    Browse the repository at this point in the history

  2. Changed ATLAS_ASSERT_MSG to ATLAS_ASSERT.

    @odlomax
    odlomax committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a5464bd View commit details
    Browse the repository at this point in the history

  3. Fixed incorrect check for successful cast in SphericalVector construc… 

    …tor.
    @odlomax
    odlomax committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    3656462 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Removed SFINAE.

    @odlomax
    odlomax committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    bd6f482 View commit details
    Browse the repository at this point in the history

  2. Replaced lambda expressions with private class methods.

    @odlomax
    odlomax committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c804d22 View commit details
    Browse the repository at this point in the history

  3. Removed NVCOMPILER macros.

    @odlomax
    odlomax committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    29ae7fc View commit details
    Browse the repository at this point in the history

  4. Removed some duplicated code in multiplyAdd method.

    @odlomax
    odlomax committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    00c2d4b View commit details
    Browse the repository at this point in the history