Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fortran access to device data through Field and FieldSet #232

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

sbrdar
Copy link
Collaborator

@sbrdar sbrdar commented Oct 10, 2024

  • add access to the device pointer in atlas_Field_module and atlas_FieldSet_module for the 'deviceptr' clause of OpenACC
  • add sync_host_device;

@sbrdar sbrdar changed the title Add a few device operators to Field and FieldSet Add access to device data through Field and FieldSet (for OpenACC) Oct 10, 2024
@wdeconinck wdeconinck force-pushed the feature/device_data branch 2 times, most recently from e3bcb94 to a7897b9 Compare October 14, 2024 08:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.39535% with 161 lines in your changes missing coverage. Please review.

Project coverage is 79.44%. Comparing base (44850d9) to head (a7897b9).
Report is 36 commits behind head on develop.

Files with missing lines Patch % Lines
src/atlas_f/field/atlas_FieldSet_module.fypp 0.00% 128 Missing ⚠️
src/atlas/field/detail/FieldInterface.cc 0.00% 21 Missing ⚠️
src/atlas/array/ArraySpec.cc 64.70% 6 Missing ⚠️
src/atlas_f/field/atlas_Field_module.fypp 0.00% 4 Missing ⚠️
src/atlas/array/Array.h 0.00% 1 Missing ⚠️
src/atlas/field/detail/FieldImpl.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #232      +/-   ##
===========================================
- Coverage    79.63%   79.44%   -0.20%     
===========================================
  Files          802      818      +16     
  Lines        55171    56289    +1118     
===========================================
+ Hits         43933    44716     +783     
- Misses       11238    11573     +335     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/11325735152.

Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed offline and changes have been pushed.
Thanks for this nice work allowing us to now use !$acc data deviceptr clause in Fortran!

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/11327419150.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/11331397080.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/11331564972.

sbrdar and others added 6 commits October 14, 2024 22:30
Co-authored-by: Willem Deconinck <willem.deconinck@ecmwf.int>
Co-authored-by: Willem Deconinck <willem.deconinck@ecmwf.int>
Co-authored-by: Willem Deconinck <willem.deconinck@ecmwf.int>
Co-authored-by: Willem Deconinck <willem.deconinck@ecmwf.int>
Co-authored-by: Willem Deconinck <willem.deconinck@ecmwf.int>
@wdeconinck wdeconinck changed the title Add access to device data through Field and FieldSet (for OpenACC) Add Fortran access to device data through Field and FieldSet Oct 14, 2024
@wdeconinck wdeconinck merged commit 9130c18 into develop Oct 14, 2024
110 checks passed
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/11335285755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants