Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application of limiter for StructuredInterpolation2D #236

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

wdeconinck
Copy link
Member

This fixes an issue where the "limiter" configuration for StructuredInterpolation2D was not having any effect.
The fix is to propagate the option to the underlying Kernel.

Also an error is thrown when the "limiter" option is used in conjunction with the use of a matrix, as that is not supported.
So to enable the limiter one should both set "matrix_free=true" and "limiter=true".

@wdeconinck wdeconinck force-pushed the fix-interpolation-structured2d-with-limiter branch from 9a66167 to 91c6430 Compare November 15, 2024 15:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 8.60215% with 85 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (44850d9) to head (4a59c34).
Report is 48 commits behind head on develop.

Files with missing lines Patch % Lines
...od/structured/kernels/QuasiCubicHorizontalKernel.h 0.00% 28 Missing ⚠️
.../method/structured/kernels/CubicHorizontalKernel.h 0.00% 19 Missing ⚠️
...method/structured/kernels/CubicHorizontalLimiter.h 0.00% 16 Missing ⚠️
...method/structured/kernels/LinearHorizontalKernel.h 0.00% 16 Missing ⚠️
...on/method/structured/StructuredInterpolation2D.tcc 57.14% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    79.63%   79.82%   +0.19%     
===========================================
  Files          802      815      +13     
  Lines        55171    64522    +9351     
===========================================
+ Hits         43933    51502    +7569     
- Misses       11238    13020    +1782     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wdeconinck wdeconinck merged commit b1eaef2 into develop Nov 18, 2024
163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants