Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds saving model on ctrl + c in Python during training #160

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

Ivan-267
Copy link
Collaborator

@Ivan-267 Ivan-267 commented Dec 4, 2023

This PR resolves #150.

This feature was also previously asked about on Discord.

@Ivan-267 Ivan-267 requested a review from edbeeching December 4, 2023 17:18
@Ivan-267 Ivan-267 changed the title Adds saving model on ctrl + c in Python during training Adds saving model on ctrl + c in Python during training Dec 4, 2023
@Ivan-267 Ivan-267 marked this pull request as draft December 8, 2023 13:43
@Ivan-267 Ivan-267 marked this pull request as ready for review December 8, 2023 14:22
@Ivan-267
Copy link
Collaborator Author

Ivan-267 commented Dec 8, 2023

I tested this a bit while training an env, there was a small issue but it was env related.
It seems the PR solution is working OK so far.

Copy link
Owner

@edbeeching edbeeching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, LGTM. Thanks

@Ivan-267 Ivan-267 merged commit 981794c into main Dec 19, 2023
12 checks passed
@Ivan-267 Ivan-267 deleted the sb3_example_save_on_ctrl_c branch December 19, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[potential todo, enhancement] Save / export model after CTRL+C is pressed for sb3
2 participants