Skip to content

Commit

Permalink
Added clarity to sidebar docs
Browse files Browse the repository at this point in the history
  • Loading branch information
edcarroll committed Mar 28, 2017
1 parent 70ee3bc commit 25cd5d7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion components/popup/popup.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export class SuiPopupDirective {
const factory = this._componentFactoryResolver.resolveComponentFactory(SuiPopup);
this._popupComponentRef = this._viewContainerRef.createComponent(factory);

// Append the generated element to the body to avoid any positioning issues.
// Move the generated element to the body to avoid any positioning issues.
document.querySelector("body").appendChild(this._popupComponentRef.location.nativeElement);

this._popup.onClose.subscribe(() => {
Expand Down
1 change: 1 addition & 0 deletions demo/src/app/pages/sidebar/sidebar.page.html
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ <h4 class="ui header">Direction</h4>
<sidebar-example-direction></sidebar-example-direction>
</div>
</demo-example>
<p>For a full page sidebar, just place all of your page content within a <code>sui-sidebar-container</code>.</p>
<h2 id="api" class="ui dividing header">API</h2>
<demo-api [api]="api"></demo-api>
</demo-page-content>

0 comments on commit 25cd5d7

Please sign in to comment.