Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for iOS and fully working with Android (including Oreo, Pie, Q) #46

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

woffu
Copy link

@woffu woffu commented Aug 20, 2019

  • IOS, We fixed the issue with the RNBoundary.podspec
  • Android, We fixed the issue with startService when the app is in background and correctly handling it using a startForegroundService with a binded notification.

@gate8team
Copy link

Any news on the delivery date for the fix?

@AlekseiSkrebkov
Copy link

When do you think this fix will be merged?

@johnou
Copy link

johnou commented Sep 9, 2019

cc @eddieowens

@grubstarstar
Copy link

@eddieowens is this going to be merged or should I use @woffu's fork?

"name": "react-native-boundary",
"version": "1.1.1",
"description": "native geofencing and region monitoring",
"name": "react-native-boundary-woffu",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woffu revert name / repo changes.

@mathiasmoeller
Copy link

Any news if this will be merged?

@mathiasmoeller
Copy link

@woffu Your fixes seem to work! Great stuff.
But could you maybe give me an example on how to handle events when the app was killed?
I add some boundaries, I attach EXIT and ENTER listeners. Everything works while the app is in foreground or in background.
When I kill the app and leave the boundary, I can see in the React Native Debugger that the App is triggered. The console logs an onExit event from the boundary index.js file. But the listeners that I attached are not called. I guess the reason is that they were destroyed when the app was killed.
I tried to attach the listeners again on App start in my index.js file (I guess that is the earliest time I can do something) but it did not work.
Since you worked with this feature could you maybe give me an example on how you listened to ENTER/EXIT events when the app was killed?
Help is very much appreciated!

@cladjules
Copy link

Hi @woffu ,
great work, thanks for the PR!

That PR has been open for months and there is no update,
I need to do the same fix for iOS (work in the background), I have merged it in my own PR #56

I wonder if we should start maintaining that project in another github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants