Query remote/cloud instances for extensions. #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Jan 10, 2025
src/portable/extension.rs
Outdated
| @@ -53,27 +55,65 @@ fn get_local_instance(options: &Options) -> Result<InstanceInfo, anyhow::Error> | |||
| Ok(inst) | |||
| } | |||
|
|
|||
| #[tokio::main(flavor = "current_thread")] | |||
There was a problem hiding this comment.
This seems out of place...
There was a problem hiding this comment.
Oh I see, this is being used to convert the function to a blocking one. I didn't know you could do this. It's not ideal -- I would recommend creating yourself a new tokio runtime and using block_on (see
Line 160 in dbe9f20
mmastrac
reviewed
Jan 10, 2025
| .unwrap_or_default(); | ||
| table.add_row(row![name, version]); | ||
| } | ||
| table.set_titles(row!["Name", "Version"]); |
mmastrac
reviewed
Jan 10, 2025
src/portable/extension.rs
Outdated
| let extension_loader = inst.extension_loader_path()?; | ||
| let output = run_extension_loader(&extension_loader, Some("--list-packages"), None::<&str>)?; | ||
| let value: serde_json::Value = serde_json::from_str(&output)?; | ||
| let extensions: Vec<ExtensionInfo> = (|| { |
There was a problem hiding this comment.
Generally it would be better to create a new function rather than define a closure and immediately execute it.
dnwpark
force-pushed
the
extension-list-remote
branch
from
cee441b to
e4ecf05
Compare
dnwpark
force-pushed
the
extension-list-remote
branch
from
e4ecf05 to
70499c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to
egedb extension listfor remote and cloud instances.Close #1437
Running with a remote dev instance produced:
Running with a cloud instance produced: