Fix some bugs in toEdgeQL when using e.with
#1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
approved these changes
Dec 11, 2024
Opened an issue for this: #1155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on discord: https://discord.com/channels/841451783728529451/1313928437886619738
Fix 1:
While debugging realised the original query is incorrect: the expressions being added to the
withblock can't reference the select expression the with block is attached to, as that select can't be hoisted into a var in it's own with block. The expression tree walker was not checking for this case (an expr's parent also being one of its child exprs), which could cause an infinite loop intoEgdeQL.Fix 2:
We check in
toEdgeQLthat all the places where a repeated expr is used exist within the scope of the with block it's being hoisted to. Here we were incorrectly not considering expressions already explicitly bound to that with block to be valid scopes.