feat: initial protocol definition #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgallor
force-pushed
the
protocol-definition
branch
from
b08fc2e to
120599a
Compare
rbino
reviewed
Sep 22, 2023
harlem88
requested changes
Sep 26, 2023
rgallor
force-pushed
the
protocol-definition
branch
from
120599a to
0d190dc
Compare
harlem88
requested changes
Oct 5, 2023
rbino
requested changes
Oct 5, 2023
rgallor
force-pushed
the
protocol-definition
branch
from
0d190dc to
114081d
Compare
noaccOS
reviewed
Oct 6, 2023
There was a problem hiding this comment.
We should also add an Internal message type, which should not be forwarded but instead parsed by us.
One such use for this message type would be when the server receives a response with an id it doesn't know, so it informs the device it should close the connection as well.
When either part receives a close frame for id j:
- they close the connection if they know id
j - otherwise, they ignore the request
harlem88
approved these changes
Oct 10, 2023
rgallor
force-pushed
the
protocol-definition
branch
2 times, most recently
from
eceab75 to
746ff56
Compare
|
Message Id restored into each protocol |
harlem88
approved these changes
Oct 12, 2023
Signed-off-by: rgallor <riccardo.gallo@secomind.com>
rgallor
force-pushed
the
protocol-definition
branch
from
746ff56 to
d3a3fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.