Fix to parse IPv6 inside brackets in the config urls #185
Conversation
| let host = match maybe_an_ip { | ||
| Some(ip) => ip.to_string(), // WARNING the verbatim IP in `raw` may be outputed in a canonical form | ||
| None => { | ||
| // FIXME: the val[2] could still be an hostname or dns name |
There was a problem hiding this comment.
Not quite sure if this is actually the behavior desired for listening.
We might need two different functions (one for IPs and one for hosts), or pass the raw string through an additional IP parsing step.
In any case, the API of this is not sufficient.
|
@raphaelhetzel @cgeoffroy sorry what are the plans re: this PR? I understand the changes by themselves may not automatically enable IPv6, but is there any reason why we shouldn't merge this (there's also a new unit test)? |
|
@cgeoffroy can merge this (I believe we just did not communicate that very well). |
Ah OK. Well, @cgeoffroy can you do a |
Add some tests to verify host parsing behavior and provide some fixes to the parsing function to better handle IPv6 hosts.
The problem is that in URL, IPv6 are surrounded with brackets
[]which are not removed after parsing.