Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gRPC API #52

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Refactor gRPC API #52

merged 1 commit into from
Sep 21, 2023

Conversation

ccicconetti
Copy link
Member

Split proto file in services + messages.

Rename package agent_api -> edgeless_api.

Split proto file in services + messages.

Rename package agent_api -> edgeless_api.
@ccicconetti ccicconetti linked an issue Sep 20, 2023 that may be closed by this pull request
@raphaelhetzel
Copy link
Collaborator

I actually thought of splitting across the different services (to limit the interfaces a dev working on a subset needs to read), but that might not be needed.

@ccicconetti ccicconetti merged commit 9aaf10c into main Sep 21, 2023
@ccicconetti ccicconetti deleted the 13-split-proto-file branch September 21, 2023 07:07
@ccicconetti
Copy link
Member Author

I actually thought of splitting across the different services (to limit the interfaces a dev working on a subset needs to read), but that might not be needed.

Yeah, I thought a lot about that option, too. Then I realized that:

  1. for now the services are very compact (even with comments)
  2. splitting the services is trivial and it does not have any impact on crates other than edgeless_api

So basically we can do further splitting as the API grows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split .proto file
2 participants