Fix webhook certificates always being issued for the marblerun namespace when installing with CLI
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs canceled.
|
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
fix/cli/injector-namespace
branch
from
ce05e1f
to
4141c23
Compare
… to one cluster Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
fix/cli/injector-namespace
branch
from
4141c23
to
734b7b5
Compare
thomasten
approved these changes
Feb 1, 2024
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.4introduced the--namespaceflag, which allows users to interact with MarbleRun deployed to non-default Kubernetes namespaces.This also allows users to install MarbleRun to different namespaces using just the CLI.
However, when creating the certificate used by MarbleRun's webhook, the DNS name was in all cases incorrectly issued for the
marblerunnamespace, instead of the namespace MarbleRun was being installed into.Proposed changes