deps: Update EGo, ERT and Go versions #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
deps/update-go
branch
from
770e0c3 to
a702208
Compare
thomasten
reviewed
Mar 12, 2024
| @@ -25,6 +25,9 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | |||
|
|
|||
| - run: | | |||
| git config --global --add safe.directory "$GITHUB_WORKSPACE" | |||
There was a problem hiding this comment.
Do you know why this is needed now and wasn't needed before?
There was a problem hiding this comment.
I'm not 100% sure, but golangci-lint with Go 1.21 seems to have issues with buildvcs otherwise.
We already use the same git command to mark the repository safe for the unittest workflow, but didnt here, since so far golangci-lint didnt complain
thomasten
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
v1.5.0v1.21.8v0.4.3