Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coordinator: atomically replace the sealed data file on store commit #762

Merged
merged 1 commit into from
Nov 13, 2024
Merged

coordinator: atomically replace the sealed data file on store commit #762

merged 1 commit into from
Nov 13, 2024

Conversation

thomasten
Copy link
Member

Currently, the state file is overwritten on each change. This has drawbacks:

  • If the write operation fails, the file may be corrupted.
  • Live backup of the file may produce a corrupt backup if it happens concurrently to a state update.

Proposed changes

  • Write state to temp file, then rename, which is an atomic operation.

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit 74468fa
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/6734a03f698804000832cee4

@thomasten thomasten merged commit 82dc444 into master Nov 13, 2024
8 checks passed
@thomasten thomasten deleted the t/atom branch November 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasten @daniel-weisse