Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the effects of path separator #49

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Clarify the effects of path separator #49

merged 3 commits into from
Sep 16, 2024

Conversation

xuhdev
Copy link
Member

@xuhdev xuhdev commented Jun 18, 2024

This is consistent with the rules from .gitignore: https://git-scm.com/docs/gitignore

If there is a separator at the beginning or middle (or both) of the
pattern, then the pattern is relative to the directory level of the
particular .gitignore file itself. Otherwise the pattern may also match
at any level below the .gitignore level.

Since we intend to be consistent with .gitignore, this part of the spec has been unclear.

Fix editorconfig/editorconfig#509


📚 Documentation preview 📚: https://editorconfig-specification--49.org.readthedocs.build/

This is consistent with the rules from `.gitignore`: <https://git-scm.com/docs/gitignore>

> If there is a separator at the beginning or middle (or both) of the
> pattern, then the pattern is relative to the directory level of the
> particular .gitignore file itself. Otherwise the pattern may also match
> at any level below the .gitignore level.

Since we intend to be consistent with `.gitignore`, this part of the
spec has been unclear.

Fix editorconfig/editorconfig#509
@xuhdev xuhdev requested a review from cxw42 June 18, 2024 21:30
@xuhdev
Copy link
Member Author

xuhdev commented Jun 18, 2024

And we have been unclear with slashes at the end because it didn't matter as matching directories is pointless...

@xuhdev xuhdev requested a review from florianb June 20, 2024 21:46
Copy link
Member

@cxw42 cxw42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few comments.

Depending on whether the tests break existing behaviour, we might need to bump the minor version.

index.rst Outdated Show resolved Hide resolved
index.rst Show resolved Hide resolved
xuhdev and others added 2 commits September 15, 2024 18:25
Co-authored-by: Chris White <cxwembedded@gmail.com>
@xuhdev xuhdev merged commit 90b274e into master Sep 16, 2024
2 checks passed
@xuhdev xuhdev deleted the sep branch September 16, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meaning of a glob like a/*.c
2 participants