fix: Prevent API call on re-filter selection

edx · Jul 19, 2024 · ccfce12 · ccfce12
1 parent 423af47
commit ccfce12
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/dashboard/src/main/java/org/openedx/courses/presentation/AllEnrolledCoursesView.kt b/dashboard/src/main/java/org/openedx/courses/presentation/AllEnrolledCoursesView.kt
@@ -137,7 +137,7 @@ fun AllEnrolledCoursesView(
                 }
 
                 is AllEnrolledCoursesAction.FilterChange -> {
-                    viewModel.getCourses(action.courseStatusFilter)
+                    viewModel.changeFilter(action.courseStatusFilter)
                 }
             }
         }

diff --git a/dashboard/src/main/java/org/openedx/courses/presentation/AllEnrolledCoursesViewModel.kt b/dashboard/src/main/java/org/openedx/courses/presentation/AllEnrolledCoursesViewModel.kt
@@ -52,7 +52,8 @@ class AllEnrolledCoursesViewModel(
     val uiMessage: SharedFlow<UIMessage>
         get() = _uiMessage.asSharedFlow()
 
-    private val currentFilter: MutableStateFlow<CourseStatusFilter> = MutableStateFlow(CourseStatusFilter.ALL)
+    private val currentFilter: MutableStateFlow<CourseStatusFilter> =
+        MutableStateFlow(CourseStatusFilter.ALL)
 
     private var job: Job? = null
 
@@ -67,6 +68,12 @@ class AllEnrolledCoursesViewModel(
         internalLoadingCourses(courseStatusFilter ?: currentFilter.value)
     }
 
+    fun changeFilter(courseStatusFilter: CourseStatusFilter?) {
+        if (courseStatusFilter != currentFilter.value) {
+            getCourses(courseStatusFilter)
+        }
+    }
+
     fun updateCourses() {
         viewModelScope.launch {
             try {