fix: Address PR comments

edx · Nov 26, 2024 · fc8d826 · fc8d826
1 parent ec42e4e
commit fc8d826
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt b/course/src/main/java/org/openedx/course/presentation/unit/video/YoutubeVideoUnitFragment.kt
@@ -219,12 +219,7 @@ class YoutubeVideoUnitFragment : Fragment(R.layout.fragment_youtube_video_unit)
                     }
                 }
                 youTubePlayer.addListener(youtubeTrackerListener)
-//                viewModel.logLoadedCompletedEvent(
-//                    viewModel.videoUrl,
-//                    true,
-//                    viewModel.getCurrentVideoTime(),
-//                    CourseAnalyticsKey.YOUTUBE.key
-//                )
+                viewModel.logVideoLoadedEvent(viewModel.videoUrl)
             }
         }
 

diff --git a/discussion/src/main/java/org/openedx/discussion/presentation/BaseDiscussionViewModel.kt b/discussion/src/main/java/org/openedx/discussion/presentation/BaseDiscussionViewModel.kt
@@ -122,7 +122,7 @@ open class BaseDiscussionViewModel(
 
     private fun logEvent(event: DiscussionAnalyticsEvent, params: Map<String, Any?>) {
         analytics.logEvent(
-            event = event.name,
+            event = event.eventName,
             params = buildMap {
                 put(DiscussionAnalyticsParam.NAME.key, event.biValue)
                 put(DiscussionAnalyticsParam.COURSE_ID.key, courseId)

diff --git a/...rc/main/java/org/openedx/discussion/presentation/responses/DiscussionResponsesFragment.kt b/...rc/main/java/org/openedx/discussion/presentation/responses/DiscussionResponsesFragment.kt
@@ -178,8 +178,8 @@ class DiscussionResponsesFragment : Fragment() {
     }
 
     companion object {
-        private const val ARG_COURSE_ID = "argCourseId"
-        private const val ARG_THREAD_ID = "argThreadId"
+        private const val ARG_COURSE_ID = "courseId"
+        private const val ARG_THREAD_ID = "threadId"
         private const val ARG_COMMENT = "comment"
         private const val ARG_IS_CLOSED = "isClosed"