refactor: Enhance Social Authentication on Sign In and Sign Up Screens #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: LEARNER-10256
Fixes: LEARNER-10256
Fixes: LEARNER-10256
Fixes: LEARNER-10256
Fixes: LEARNER-10256
HamzaIsrar12
force-pushed
the
hamza/LEARNER-10256
branch
from
ab22ec4
to
cef280c
Compare
HamzaIsrar12
requested review from
k1rill,
dixidroid,
omerhabib26 and
farhan-arshad-dev
dixidroid
approved these changes
Nov 21, 2024
omerhabib26
approved these changes
Nov 25, 2024
auth/src/main/java/org/openedx/auth/presentation/signin/SignInUIState.kt
Show resolved
Hide resolved
Fixes: LEARNER-10256
omerhabib26
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-10256 | LEARNER-10257
Screenshots:
Resources:
Note:
The "more/less" option for the social auth view has not been implemented yet. Currently, only up to three social auth options are configured on the app, making the "more/less" feature unnecessary. If additional auth options are added in the future, the "more/less" option can be implemented based on the design by Axim.