Skip to content

Commit

Permalink
fix: decrease facebook sdk version and fix open(url) calling (openedx…
Browse files Browse the repository at this point in the history
…#537)

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
  • Loading branch information
rnr and rnr authored Nov 4, 2024
1 parent f7eeae8 commit a38730c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Core/Core.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -2466,7 +2466,7 @@
repositoryURL = "https://github.com/facebook/facebook-ios-sdk";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 17.4.0;
minimumVersion = 16.3.1;
};
};
/* End XCRemoteSwiftPackageReference section */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ public struct NotAvailableOnMobileView: View {
.padding(.top, 12)
StyledButton(CourseLocalization.NotAvaliable.button, action: {
if let url = URL(string: url), UIApplication.shared.canOpenURL(url) {
UIApplication.shared.open(url)
// Added empty options to avoid calling overridden open(url) function in facebook sdk
UIApplication.shared.open(url, options: [:])
}
})
.frame(width: 215)
Expand Down

0 comments on commit a38730c

Please sign in to comment.