Skip to content

Commit

Permalink
docs: updating readme (#1)
Browse files Browse the repository at this point in the history 
* docs: updating readme

* chore: changing text to trigger GHA

* fix: update CODEOWNERS to be internal revenue-squad
  • Loading branch information
@christopappas
christopappas authored Apr 5, 2024
1 parent 5552cbf commit b2de60b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CODEOWNERS
View file
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# PCI compliance requires stricter scrutiny, see PR template
/src @openedx/revenue-squad
CODEOWNERS @openedx/revenue-squad
/src @edx/revenue-squad
CODEOWNERS @edx/revenue-squad
4 changes: 3 additions & 1 deletion README.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
frontend-app-payment
====================

Please tag **@edx/revenue-squad** on any PRs or issues. Thanks.
Please tag **@edx/revenue-squad** on any PRs or issues. Thanks!

This repo is intended for the use of 2U employees.

Introduction
------------
Expand Down

3 comments on commit b2de60b

@Silidrone
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure but I think this commit somehow breaks the release quince.1

After this commit I am getting

------
 > git://github.com/edx/frontend-app-payment.git#open-release/quince.1:
------
ERROR: failed to solve: failed to load cache key: repository does not contain ref open-release/quince.1, output: ""
Error: Command failed with status 1: docker buildx build --tag=docker.io/overhangio/openedx-mfe:17.0.0 --output=type=docker --cache-from=type=registry,ref=docker.io/overhangio/openedx-mfe:17.0.0-cache --build-context=authn-src=/home/silidrone/.local/share/tutor/frontend-app-authn --build-context=learning-src=/home/silidrone/.local/share/tutor/frontend-app-learning --build-context=learner-dashboard-src=/home/silidrone/.local/share/tutor/frontend-app-learner-dashboard /home/silidrone/.local/share/tutor/env/plugins/mfe/build/mfe

After I run: tutor images build mfe on tutor quince1

@christopappas
Copy link
Author

@christopappas christopappas commented on b2de60b Apr 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, I think the build tool you're using may need to point to openedx going forward (e.g. git://github.com/openedx/frontend-app-payment.git instead of git://github.com/edx/frontend-app-payment.git). edX/2U is currently in the processes of forking a few repositories (specifically: this and frontend-app-ecommerce) to unblock the community, but it would appear what you're experiencing is an unintended side effect of that work. Particularly, when we forked the repository, we only copied the master branch over (and not all the openedx release branches too)

@christopappas
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created this PR to tutor-ecommerce, which I think may resolve the issue: overhangio/tutor-ecommerce#74

Please sign in to comment.