feat: added paypal param redirect #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, but this repo does not accept outside contributions unless they are under contract. If you think this is an error, please contact @nedbat. |
grmartin
changed the title
grmartin
reviewed
Jul 5, 2024
|
You need to rework your commit messages to follow the conventional commit rules... https://open-edx-proposals.readthedocs.io/en/latest/best-practices/oep-0051-bp-conventional-commits.html Rebase, edit messages then force push. |
NawfalAhmed
reviewed
Jul 8, 2024
bdizha
force-pushed
the
bmatuku/SONIC-501-added-paypal-param-redirect
branch
2 times, most recently
from
bedbe0f
to
a65b4bc
Compare
bdizha
force-pushed
the
bmatuku/SONIC-501-added-paypal-param-redirect
branch
from
a65b4bc
to
3a8fcbe
Compare
|
This is related to the following PRs: |
bdizha
commented
Jul 8, 2024
|
Bata has signed off, time to create a new PR to get past the CLA issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is intended as a temporary measure to allow users to pay via PayPal, until we implement full PayPal support in the new checkout.
Acceptance Criteria
When arriving at legacy checkout
-- any previously applied coupon is re-applied
-- the PayPal flow is immediately initiated, and the user is brought to PayPal to complete their transaction
Completing the PayPal transaction results in a successful order and fulfillment in the legacy system