Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pageType to Checkout window #28

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat: Add pageType to Checkout window #28

merged 2 commits into from
Nov 7, 2024

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Nov 7, 2024 •
edited
Loading

For Red Ventures event tracking, Cohesion/Beam needs the pageType to be added to the window object.

This PR:

  • Adding pageType on load of the Checkout component
  • Edits to the data structure that the API expects.

@julianajlk julianajlk requested a review from a team as a code owner November 7, 2024 15:54
@julianajlk julianajlk merged commit fc00ab9 into master Nov 7, 2024
4 checks passed
@julianajlk julianajlk deleted the julianajlk/RV/EDX-932/rv-eventing-fix branch November 7, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grmartin grmartin grmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianajlk @grmartin