Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load fore dependency from npm #38

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Load fore dependency from npm #38

wants to merge 1 commit into from

Conversation

line-o
Copy link
Member

@line-o line-o commented Oct 6, 2023 •
edited
Loading

fixes #37

  • add Fore to dependencies in package.json
  • add gulp task to copy Fore resources to build folder
  • update Fore library to its current release version 1.8.0

ISSUES

with 1.8.0 login is unsuccessful because /login returns

{ user: null }

@line-o line-o changed the title wip: load fore dependency from npm Load fore dependency from npm Oct 12, 2023
@line-o line-o requested review from duncdrum and JoernT October 12, 2023 13:25
@line-o line-o marked this pull request as draft October 12, 2023 13:42
@JoernT
Copy link

JoernT commented Nov 2, 2023 •
edited
Loading

what's the rationale behind /login returning a 200 but with user null? Shouldn't that be a 403?

We can catch the case within the submission however just wondering...

@line-o
Copy link
Member Author

line-o commented Nov 2, 2023

The login does not work after updating fore so it does work with the current bundled version of fore but not with 1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum approved these changes

@JoernT JoernT Awaiting requested review from JoernT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load fore from node modules
3 participants
@line-o @JoernT @duncdrum