Merge pull request #6 from eendebakpt/singledispatchmethod3b

Eliminate caching variable
eendebakpt · Aug 1, 2023 · 307f0c1 · 307f0c1
2 parents ca691e8 + e8eeedd
commit 307f0c1
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/Lib/functools.py b/Lib/functools.py
@@ -949,13 +949,11 @@ def __get__(self, obj, cls=None):
             try:
                 _method = self._method_cache[obj]
             except TypeError:
-                self._all_weakrefable_instances = caching = False
+                self._all_weakrefable_instances = False
             except KeyError:
-                caching = True
+                pass
             else:
                 return _method
-        else:
-            caching = False
 
         def _method(*args, **kwargs):
             method = self.dispatcher.dispatch(args[0].__class__)
@@ -965,7 +963,7 @@ def _method(*args, **kwargs):
         _method.register = self.register
         update_wrapper(_method, self.func)
 
-        if caching:
+        if self._all_weakrefable_instances:
             self._method_cache[obj] = _method
 
         return _method