Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework DIP-56 #171

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Rework DIP-56 #171

merged 1 commit into from
Oct 25, 2024

Conversation

ligi
Copy link
Member

@ligi ligi commented Oct 23, 2024

replaces #163

Related DIP issue

Checklist

  • Correct markdown (e.g. headers with ##, header surrounded by ---)
  • syntax check
  • filename is DIP-X.md (with X being the correct DIP number)
  • header contains (in this order)
    • DIP
    • Title
    • Status
    • Themes
    • Tags
    • Authors
    • Resources Required (optional)
    • Discussion (with link to devcon forum)
    • Created (in the format year-month-day e.g 2020-4-20)
  • contains these sections:
    • Abstract
    • Rationale
    • Implementation
    • Operational Requirements & Ownership
  • PR title prefixed with DIP-X

ng-rgb
ng-rgb approved these changes Oct 25, 2024
View reviewed changes
Copy link

@ng-rgb ng-rgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks so much for your help!

@ligi ligi merged commit aa86813 into master Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ng-rgb ng-rgb ng-rgb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ligi @ng-rgb