Add types to symbol outline #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonathan Immanuel Brachthäuser <jonathan@b-studios.de>
b-studios
reviewed
Jul 30, 2024
| val ScopesForFile = Annotation[kiama.util.Source, List[symbols.scopes.Scope]]( | ||
| "ScopesForFile", | ||
| "all scopes for file" | ||
| ) |
There was a problem hiding this comment.
This might lead to a lot of allocation, but this is a general problem.
|
Hey @marvinborner what are the next steps here? |
|
I'm really not sure. As discussed, annotating the scopes adds a lot of allocations. I think we need to find a better (and cached) solution, and also cache other stages first. Otherwise, merging (something like) this will decrease LSP's performance a lot. (or we just merge the basic implementation before scope annotations, as an initial solution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #396. I also added collapsible items for imports and namespaces.
I'm not sure how to get the types of sub-level symbols yet, so I just put a '?' when the type is not available. We also need to add some kind of caching so the outline doesn't flicker when the file can't be processed (ie. while actively typing).