Emit ES modules from JavaScript backend #511
Draft
+35
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disclaimer: most of this PR was written by Claude 3.5 Sonnet
|
On Windows, the hack to load a file dynamically without ES modules doesn't work, because there it's a Instead, we might want to:
val jsScript = s"""
|import { main } from '${mjsFilePath}';
|main();
""".stripMargin |
jiribenes
commented
Sep 9, 2024
Comment on lines
171
to
174
| // NOTE: This is a hack since this file cannot use ES imports & exports | ||
| // because it doesn't have the .mjs ending. Sigh. | ||
| // Also, we add the 'file://' prefix to satisfy Windows. | ||
| val jsScript = s"import('file://${mjsFileName}').then(({main}) => { main(); })" |
There was a problem hiding this comment.
I'll need to revisit this: the path should be relative (see #566).
There was a problem hiding this comment.
Let's just try using file:filename instead 🤔
Suggested change
| // NOTE: This is a hack since this file cannot use ES imports & exports | |
| // because it doesn't have the .mjs ending. Sigh. | |
| // Also, we add the 'file://' prefix to satisfy Windows. | |
| val jsScript = s"import('file://${mjsFileName}').then(({main}) => { main(); })" | |
| // NOTE: This is a hack since this file cannot use ES imports & exports | |
| // because it doesn't have the .mjs ending. Sigh. | |
| // Also, we add the 'file:' prefix to satisfy Windows. | |
| val jsScript = s"import('file:${mjsFileName}').then(({main}) => { main(); })" |
There was a problem hiding this comment.
Uhoh.
(node:8164) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_FILE_URL_PATH]: File URL path must be absolute
I'll need to think about this, worstcase we need to dynamically get the current file in JS...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #405
Disclaimer: most of this PR was written by Claude 3.5 Sonnet
TODO
.thenloaderHow to use in the browser