LLVM: Pass stack instead of stack pointer #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinborner
commented
Aug 16, 2024
phischu
force-pushed
the
feature/llvm-stack-passing
branch
2 times, most recently
from
5a06f4e
to
408a335
Compare
phischu
force-pushed
the
feature/llvm-stack-passing
branch
2 times, most recently
from
d18e75a
to
276610f
Compare
phischu
force-pushed
the
feature/llvm-stack-passing
branch
from
276610f
to
91ccfbd
Compare
phischu
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't doing anything yet, most things are incomplete/wrong.
Edit:
All tests are passing now locally. We may have introduced new leaks though, so the Valgrind tests will likely fail.