Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roxygen2 documentation for all functions #102

Open
9 tasks
egouldo opened this issue Aug 11, 2024 · 1 comment · Fixed by #106
Open
9 tasks

roxygen2 documentation for all functions #102

egouldo opened this issue Aug 11, 2024 · 1 comment · Fixed by #106

Comments

@egouldo
Copy link
Owner

egouldo commented Aug 11, 2024

  • function name
  • description
  • details
  • all params
  • Ensure all exported, where relevant otherwise, set to internal function
  • ensure all fns have @import or @importFrom calls
    • ensure not mix and matching @importFrom and @import across functions
  • Examples, where relevant
    • replace ManyEcoEvo::data object calls with data(data object) after switching away from lazy loading data
@egouldo egouldo added this to the Software Manuscript Submit milestone Aug 11, 2024
@egouldo egouldo self-assigned this Aug 11, 2024
egouldo added a commit that referenced this issue Aug 11, 2024
egouldo added a commit that referenced this issue Aug 11, 2024
- rename fn title,
- give more detail in `@returns`,
- explain mechanics in `@details`,
- switch to `@import` instead of `@importFrom`,
- add `@family` and `@seealso tags`
egouldo added a commit that referenced this issue Aug 11, 2024
…umentation for `_back()` family \document
egouldo added a commit that referenced this issue Aug 11, 2024
egouldo added a commit that referenced this issue Aug 11, 2024
egouldo added a commit that referenced this issue Aug 12, 2024
egouldo added a commit that referenced this issue Aug 12, 2024
egouldo added a commit that referenced this issue Aug 12, 2024
- #102 rm duplicate tidyselect import
- required for 02151e5
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo egouldo linked a pull request Aug 12, 2024 that will close this issue
egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo
Copy link
Owner Author

egouldo commented Aug 12, 2024

/document

egouldo added a commit that referenced this issue Aug 12, 2024
@egouldo egouldo reopened this Aug 12, 2024
egouldo added a commit that referenced this issue Aug 14, 2024
- #42 #102 functionalise + document forest plot extraction
- #42 mv plot_forest into pkg and document #102
egouldo added a commit that referenced this issue Aug 14, 2024
egouldo added a commit that referenced this issue Aug 14, 2024
egouldo added a commit that referenced this issue Aug 14, 2024
egouldo added a commit that referenced this issue Aug 14, 2024
- #102 Add `@details` section for `process_response()` and add heading for `@details` in `standardise_response()`
egouldo added a commit that referenced this issue Aug 23, 2024
egouldo added a commit that referenced this issue Aug 23, 2024
egouldo added a commit that referenced this issue Aug 24, 2024
Switch to `@importFrom` tags from `@import`

Add `@seealso`, `@details` and some `@examples`

Reorganise index manual grouping structure with `@family` and `@describeIn` tags

`devtools::document()`

Refs: #97 #102
egouldo added a commit that referenced this issue Aug 26, 2024
style: linespacing / and indentation #97
egouldo added a commit that referenced this issue Aug 26, 2024
- switch arg to `data` from `ManyEcoEvo`
- expose argument to user `n_min` and `n_max`
- explicit join by argument in join
- ensure filter diversity_indices for each reduced subset
- ensure filter diversity_data on effects_analysis and NOT data

---

This step filters datasets into a `'effects_analysis'` column, and therefore any filtering of the `diversity_*` data must be based on `effects_analysis`

refs: #102 #97
egouldo added a commit that referenced this issue Aug 27, 2024
- expose filtering of subsets to user argument: ignore outlier generation for some subsets
- Expose `n_min` and `n_max` args to user
- Add argument checks #116, inc. checking filter expressions for existance of col names in `data`
- Conditionally slice depending on whether `n_*` args supplied in call
- Define internal helper fns to reduce duplicate code
- Permit multiple logical expressions in argument ignore_subsets
- Allow different values of `n_min` and `n_max` for different `dataset`s

bug!: properly evaluate whether arg `ignore_subsets` is null and parse to `filter_vars`, see `dplyr::dplyr_data_masking`

docs!: Update docs #118

- include functional updates in roxygen docs #102
- rm targets pipeline family tag

style: tidy lint #97

- linespacing / whitespace
- rm TODO comments
- Add section header comments
egouldo added a commit that referenced this issue Aug 27, 2024
egouldo added a commit that referenced this issue Aug 28, 2024
- rm commented out `poss_fit_*()` (now exported internally in 7dabe6d) #97
- replace name of data arg to `data` #97
- switch to rlang::is_null for arg checking #116 / conditional behaviour
- Add arg checking for `filter_vars`, `data`, and checking wither required columns, incl. those in `filter_vars` exist in `data` #116
- expose user-supplied arguments `outcom_variable` / `outcome_SE` and match values to arg conditions in new columns
- update supply of colnames arg to meta-analysis functions

docs!: update corresponding docs #102

- switch to `@importFrom` for `cli::`, add missing `@importFrom` calls
- Add `@details` on user-specified exclusion of outcome variable / outcome variable SE

style: spacing indentation, rm inline TODO comments #97
egouldo added a commit that referenced this issue Aug 28, 2024
…118

- `fit_MA_mv()` switch from `Z_colname` to `outcome_colname` and `VZ_colname` to `outcome_SE_colname` #118
- `calculate_deviation_score()` #118:  expose colname selection column to user , return meta-analytic mean in column, add `outcome_colname` to specify relevant outcome column name, add argument checking #116
- `apply_slice_conditionally()` create column `exclusion_set` if does not exist and switch to `se_log` as `VZ_colname` in example for eucalyptus` #188
- `box_cox_transform()` expose `outcome_SE_colname` arg, add relevant arg checks, update cli output, parse outcome_SE_columns` to `folded_params()` function call #188
- replace `std.error_log` arg with `se_log` for any logged `yi` data #188
- and update wrapper function calls in `meta_analyse_datasets()`, provide NULL default for new arg `outcome_SE` #188
- `fit_box_cox_ratings_cat()`: add arg checks #116, replace arg name `.data` with `data`, switch to `inject` approach as per `fit_box_cox_ratings_cont()` #97
- fit_box_cox_ratings_cont()` switch to `data` arg from `.data`, add arg checks #116
- add arg checks to `standardise_response()`, `fit_sorensen_glm()`, `fit_multivar_MA()` , `fit_uni_mixed_effects()` #116

docs!: update corresponding docs

- delete obsolete `@examples` code #102
- add #TODO comments #97
- add missing `@import` calls
- switch to `@importFrom` from `@import` for `purrr::` `rlang::` and `tidyr::` et al
- don't import `rlang::` in package.R

bug!: minor bug fixes

- unquote bare colname in pointblank check for `exclude_extreme_VZ()`
- `fit_metafor_mv_reduced()` replace obs_id with study_id as random effect
egouldo added a commit that referenced this issue Aug 28, 2024
- add import tag for `purrr::transpose()` in `fit_multivar_MA()` #102
- defuse argument `outcome` in `cli()` call in `fit_boxcox_ratings_cont()`

- `meta_analyse_datasets()`:
  - use correct argument in calls to `fit_boxcox_ratings_*()` (`data` from `.data`)
  - apply coalesce on list-cols only and `@import` `tidyselect::where()` (previously non-list-cols were ignored because character columns were explicitly grouped, however current approach in pipeline is ungrouped in order to allow for generalisability / scalability #87. Can't caoalesce a character vector and list, must be of same type).

build!: update calls in targets `yi` pipeline
egouldo added a commit that referenced this issue Aug 28, 2024
- style: use comments to structure function. rearrange condition checks, and helper functions. update indentation. #97
egouldo added a commit that referenced this issue Aug 28, 2024
style: fix indentation and spacing #97
egouldo added a commit that referenced this issue Aug 28, 2024
egouldo added a commit that referenced this issue Aug 29, 2024
feat!: add threshold for executing function in line with preregistered threshold (5 in each category of `mixed_model`)

style: move cli output after argument checking #97

docs: capitalise Box-Cox #102
egouldo added a commit that referenced this issue Sep 6, 2024
egouldo added a commit that referenced this issue Sep 6, 2024
egouldo added a commit that referenced this issue Sep 6, 2024
egouldo added a commit that referenced this issue Sep 9, 2024
egouldo added a commit that referenced this issue Sep 9, 2024
…s_yi()`, update call of function within `prepare_response_variables_yi()` #97

And update associated roxygen code, especially imports #102
egouldo added a commit that referenced this issue Sep 9, 2024
egouldo added a commit that referenced this issue Sep 9, 2024
egouldo added a commit that referenced this issue Sep 10, 2024
… review data cols are all re-nested

#102 add note in documentation explaining data requirements
egouldo added a commit that referenced this issue Sep 14, 2024
  - and add details explaining model structure and required data structure in roxygen documentation #102
  - don't pointblank check for box_cox column, let user's value be checked #116
  - update data checks to match required model structure #116
egouldo added a commit that referenced this issue Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant